Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch and use BS thread_pool #408

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Fetch and use BS thread_pool #408

merged 7 commits into from
Jul 24, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jul 22, 2024

Instead of hard coding the header of BS::thread_pool, we now fetch the implementation. Done for cudf in rapidsai/cudf#16210.

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 22, 2024
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jul 22, 2024
Merged
7 tasks
@KyleFromNVIDIA
Use rapids_cpm_bs_thread_pool()
3ec872c 
And temporarily link to open PR instead of mainline.
@KyleFromNVIDIA
Style
e718d3f
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 23, 2024 21:12
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 23, 2024 21:12
@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 52e0ff5 into rapidsai:branch-24.08 Jul 24, 2024
60 checks passed
@madsbk madsbk deleted the bs_thread_pool branch July 24, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA left review comments

@robertmaynard robertmaynard robertmaynard left review comments

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsbk @KyleFromNVIDIA @robertmaynard @bdice